Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(rust, python): Support min and max strategy for binary & str columns fill null #10673

Merged
merged 1 commit into from
Aug 23, 2023
Merged

feat(rust, python): Support min and max strategy for binary & str columns fill null #10673

merged 1 commit into from
Aug 23, 2023

Conversation

reswqa
Copy link
Collaborator

@reswqa reswqa commented Aug 22, 2023

This closes #10666.

@github-actions github-actions bot added enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars labels Aug 22, 2023
@reswqa reswqa changed the title feat(rust, python): Support Expr.fill_null(strategy="min") for string columns feat(rust, python): Support min and max strategy for string columns fill null Aug 22, 2023
@reswqa reswqa force-pushed the str_fill_null branch 2 times, most recently from 302051c to 633cb8b Compare August 22, 2023 17:32
@reswqa reswqa changed the title feat(rust, python): Support min and max strategy for string columns fill null feat(rust, python): Support min and max strategy for binary & string columns fill null Aug 22, 2023
@reswqa reswqa changed the title feat(rust, python): Support min and max strategy for binary & string columns fill null feat(rust, python): Support min and max strategy for binary & str columns fill null Aug 22, 2023
ritchie46
ritchie46 approved these changes Aug 23, 2023
View reviewed changes
Copy link
Member

@ritchie46 ritchie46 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks!

@ritchie46 ritchie46 merged commit 37531d5 into pola-rs:main Aug 23, 2023
25 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ritchie46 ritchie46 ritchie46 approved these changes

@stinodego stinodego Awaiting requested review from stinodego

@alexander-beedie alexander-beedie Awaiting requested review from alexander-beedie alexander-beedie is a code owner

@orlp orlp Awaiting requested review from orlp orlp is a code owner

Assignees
No one assigned
Labels
enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support Expr.fill_null(strategy="min") for string columns
2 participants
@reswqa @ritchie46