Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(rust): string to decimal parsing #10712

Merged
merged 6 commits into from
Aug 29, 2023
Merged

fix(rust): string to decimal parsing #10712

merged 6 commits into from
Aug 29, 2023

Conversation

c-peters
Copy link
Collaborator

Avoid incorrect parsing of trailing characters 12ABC.123BC

See fix #10118

@github-actions github-actions bot added fix Bug fix rust Related to Rust Polars labels Aug 24, 2023
@ritchie46
Copy link
Member

A rust fmt run and it is good to go.

@ritchie46 ritchie46 changed the title fix(rust): Str to decimal parsing fix(rust): string to decimal parsing Aug 29, 2023
@c-peters
Copy link
Collaborator Author

Simplified the match a little bit, since the first option must be Some (splitn returns Some('') for examples like .5.

@ritchie46 ritchie46 merged commit d7a7c3e into pola-rs:main Aug 29, 2023
17 checks passed
@c-peters c-peters deleted the str_to_decimal branch November 7, 2023 09:39
@alexander-beedie alexander-beedie added the A-dtype-decimal Area: decimal data type label Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ritchie46 ritchie46 ritchie46 left review comments

@orlp orlp Awaiting requested review from orlp orlp is a code owner

Assignees
No one assigned
Labels
A-dtype-decimal Area: decimal data type fix Bug fix rust Related to Rust Polars
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

str.to_decimal() weird behaviour
4 participants
@c-peters @ritchie46 @orlp @alexander-beedie