feat(rust, python): repeat_by should also support broadcasting of LHS #10735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reswqa
requested review from
ritchie46,
stinodego,
alexander-beedie and
orlp
as code owners
github-actions
bot
added
enhancement
reswqa
commented
Aug 26, 2023
|
|
||
| // SAFETY: length of iter is trusted. | ||
| unsafe { | ||
| LargeListArray::from_iter_primitive_trusted_len( |
There was a problem hiding this comment.
I believe we can share most of the code with these types, but before that, maybe we should unify this call first. 🤔
There was a problem hiding this comment.
Yes, might be a good follow up!
|
Not sure if this is by design or we can improve it. But we mark it as accepted, so open this pr first ：) |
ritchie46
approved these changes
Aug 26, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #10702.