fix(rust!, python): Error on value_counts on column named "counts"
#10737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
breaking rust
stinodego
commented
Aug 26, 2023
stinodego
commented
Aug 26, 2023
| @@ -8269,48 +8269,62 @@ def extend_constant(self, value: PythonLiteral | None, n: int) -> Self: | |||
|
|
|||
| return self._from_pyexpr(self._pyexpr.extend_constant(value, n)) | |||
|
|
|||
| def value_counts(self, *, multithreaded: bool = False, sort: bool = False) -> Self: | |||
| @deprecate_renamed_parameter("multithreaded", "parallel", version="0.19.0") | |||
| def value_counts(self, *, sort: bool = False, parallel: bool = False) -> Self: | |||
There was a problem hiding this comment.
I switched the parameters here. I believe the "what" should come before the "how". i.e. parallel won't impact the result, only how it's computed. So these params should come last if possible.
stinodego
requested review from
ritchie46,
alexander-beedie and
orlp
as code owners
stinodego
force-pushed
the
value-counts
branch
from
bcc7afc
to
210dd17
Compare
ritchie46
approved these changes
Aug 26, 2023
ritchie46
approved these changes
Aug 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10732
Also did a bunch of code cleanup.
Changes
Series.value_countsto the expression.multithreadedparam toparallel- this is more in line with other functions likeconcat.