-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Implement LazyFrame.sink_ndjson
#10786
Merged
+421
−93
Merged
Changes from all commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
6a79d0c
add json options
fernandocast f7ed446
Add API changes
fernandocast df1001e
feat: adding batched json writer
abealcantara 7c7da80
integration and fixes
abealcantara 8ecf929
small fixes
abealcantara 2d46937
small fix
abealcantara 19ca57d
refactor: new json batched writers
abealcantara c853e54
add py-polars unit testing
fernandocast dc7ed34
refactor: removing duplicated code for sink_file
abealcantara 2311d32
add unit testing for sink_json method
fernandocast 48b833a
style: fix code formatting
fernandocast 89b5de5
fix: unit tests
abealcantara 7b3d901
style: fix code formatting
abealcantara e1610cf
fix: rust lint
abealcantara 4546a7d
fix: feature check
abealcantara ee1b225
fix: using polars_json and formatting
abealcantara 6fb40ce
feature: add code style
fernandocast f22727e
add json sink features
fernandocast 38588e3
refactor fixes
abealcantara 935c58b
fix: replace match with if structure, for single_match
fernandocast da07fd8
fix: update style with pre-commit
fernandocast 4c95a5f
reverting changes in dependencies for ipc and csv
abealcantara d02b9b2
fix: removing json support
fernandocast 622899f
feat: refactoring sink method, removing deplicated code
fernandocast 3fc1786
fix: applying style format to mod.rs
fernandocast 47745b4
add feature label
fernandocast File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we have the
JsonFormat
enum, I think it may be easier to use if the batched writers were combined & accepted aJsonFormat
as an input.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed it, could you check again?