fix: Correct hash and fmt for struct expr #11119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
fix
reswqa
requested review from
ritchie46,
stinodego,
alexander-beedie and
orlp
as code owners
reswqa
commented
Sep 14, 2023
| @@ -240,6 +240,8 @@ impl Hash for FunctionExpr { | |||
| FunctionExpr::Boolean(f) => f.hash(state), | |||
| #[cfg(feature = "strings")] | |||
| FunctionExpr::StringExpr(f) => f.hash(state), | |||
| #[cfg(feature = "dtype-struct")] | |||
| FunctionExpr::StructExpr(f) => f.hash(state), | |||
There was a problem hiding this comment.
Maybe ListExpr and ArrayExpr also needs to be treated similarly?
There was a problem hiding this comment.
Yes, the more complete the better. 👍
ritchie46
approved these changes
Sep 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AExprcontainingStructFunction::FieldByNamewith differentfieldnames were calculated to have the samehashvalue, resulting in incorrect reuse bycse.This fixes #11116.