Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(python, rust): Adds NULLIF and COALESCE SQL functions #11124

Merged
merged 2 commits into from
Sep 21, 2023

Conversation

SeanTroyUWO
Copy link
Contributor

Adds a pair of functions from the Postgres SQL documentation:
https://www.postgresql.org/docs/current/functions-conditional.html#FUNCTIONS-COALESCE-NVL-IFNULL

I'm getting SQL issues from here: #7227

Apparently these were community requested, I cannot find who requested them.

@github-actions github-actions bot added enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars labels Sep 15, 2023
@SeanTroyUWO
Copy link
Contributor Author

I have no idea why that lint is mad at me.

@SeanTroyUWO
Copy link
Contributor Author

I have no idea why that lint is mad at me.

The last time those lines were changed was a year ago. I don't know why they would create an issue now.

@SeanTroyUWO
Copy link
Contributor Author

I have no idea why that lint is mad at me.

The last time those lines were changed was a year ago. I don't know why they would create an issue now.

Fixed by forwarding past #11126

@universalmind303
Copy link
Collaborator

@SeanTroyUWO seems to be broken across the board

This PR should fix it:
#11144

@ritchie46 ritchie46 merged commit d927021 into pola-rs:main Sep 21, 2023
24 checks passed
@alexander-beedie alexander-beedie added the A-sql Area: Polars SQL functionality label Jan 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-sql Area: Polars SQL functionality enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants