fix: Make pl.struct serializable #11169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
fix
reswqa
requested review from
ritchie46,
stinodego,
alexander-beedie and
orlp
as code owners
reswqa
commented
Sep 18, 2023
| @@ -3,16 +3,15 @@ use super::*; | |||
|
|
|||
| /// Take several expressions and collect them into a [`StructChunked`]. | |||
| #[cfg(feature = "dtype-struct")] | |||
| pub fn as_struct(exprs: &[Expr]) -> Expr { | |||
| map_multiple( | |||
There was a problem hiding this comment.
In the long run, do we plan to reduce the use of anonymous functions?
There was a problem hiding this comment.
Yes, in fact existing anonymous functions should be rewritten to the common style and implementation dispatched to polars-ops.
There was a problem hiding this comment.
Sounds good, I will find some time to help rewrite this. :)
ritchie46
approved these changes
Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #11100.