fix: fix nullable filter mask in group_by #11207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
fix
reswqa
commented
Sep 20, 2023
| @@ -73,7 +73,7 @@ impl PhysicalExpr for FilterExpr { | |||
| let predicate = predicate_s.bool()?; | |||
|
|
|||
| // All values true - don't do anything. | |||
| if predicate.all() { | |||
| if let Some(true) = predicate.all_kleene() { | |||
There was a problem hiding this comment.
If predicate only has null and true, all will return true and return the non-filtered series directly, this looks a bit strange. IIUC, value masked by None should also be filtered out. WDYT?
There was a problem hiding this comment.
We should do the same as in the select context. I see that we only return the true values there. So yes this seems correct.
reswqa
requested review from
ritchie46,
stinodego,
alexander-beedie and
orlp
as code owners
ritchie46
approved these changes
Sep 20, 2023
| @@ -73,7 +73,7 @@ impl PhysicalExpr for FilterExpr { | |||
| let predicate = predicate_s.bool()?; | |||
|
|
|||
| // All values true - don't do anything. | |||
| if predicate.all() { | |||
| if let Some(true) = predicate.all_kleene() { | |||
There was a problem hiding this comment.
We should do the same as in the select context. I see that we only return the true values there. So yes this seems correct.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #11204.