Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(python): document simd-json max size limit #11245

Closed
wants to merge 0 commits into from

Conversation

moritzwilksch
Copy link
Contributor

This limitation was previously undocumented in polars. Since polars passes through the InputTooLarge error from simd-json, this PR makes the docs more specific as to what the actual limit is.

@github-actions github-actions bot added documentation Improvements or additions to documentation python Related to Python Polars labels Sep 22, 2023
@ritchie46
Copy link
Member

Didn't know about that limit. Maybe we can circumvent it somehow.

@moritzwilksch
Copy link
Contributor Author

That would of course be even better :D Currently polars concats all rows with ,, wraps them in [ ], and then sends the data off to simd-json, right? I guess circumventing the simd-json limit would require a significant change to that logic? Or maybe some kind of partitioning?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation python Related to Python Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants