Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: str.splitn and split_exact can take an expr argument by #11275

Merged
merged 1 commit into from
Sep 24, 2023
Merged

feat: str.splitn and split_exact can take an expr argument by #11275

merged 1 commit into from
Sep 24, 2023

Conversation

reswqa
Copy link
Collaborator

@reswqa reswqa commented Sep 23, 2023

No description provided.

@github-actions github-actions bot added enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars labels Sep 23, 2023
@reswqa reswqa marked this pull request as ready for review September 24, 2023 07:24
ritchie46
ritchie46 approved these changes Sep 24, 2023
View reviewed changes
Copy link
Member

@ritchie46 ritchie46 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work! The great expressification 🌈

@ritchie46 ritchie46 merged commit f60a968 into pola-rs:main Sep 24, 2023
26 checks passed
@reswqa reswqa deleted the str_splitn branch September 24, 2023 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ritchie46 ritchie46 ritchie46 approved these changes

@stinodego stinodego Awaiting requested review from stinodego

@alexander-beedie alexander-beedie Awaiting requested review from alexander-beedie alexander-beedie is a code owner

@orlp orlp Awaiting requested review from orlp orlp is a code owner

Assignees
No one assigned
Labels
enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@reswqa @ritchie46