chore(python): Pin pydantic in dev requirements <2.4.0
#11312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
internal
stinodego
requested review from
ritchie46 and
alexander-beedie
as code owners
|
Hey @stinodego thanks for raising this. I'll dig into this |
1 task
|
Looks like this has already reported at Pydantic: pydantic/pydantic#7611 |
|
Thanks for pinging me |
romanovacca
pushed a commit
to romanovacca/polars
that referenced
this pull request
Oct 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new release of pydantic (
2.4.0) broke some of the pyiceberg tests.Not really sure how to properly solve this. I guess the folks over at pyiceberg must release a fix to support the new pydantic version, and/or pydantic must issue a new release to revert the breaking change.
@Fokko Could you track down the issue here?