depr(python): Deprecate DataType.is_nested
#11844
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I really like the idea of extending our
DataType
class with methods likeis_nested()
andis_integer()
(and other groups). But these should not be properties - they should be (class)methods just like we haveSeries.is_integer()
andDataFrame.is_empty()
etc.Unfortunately,
is_nested
is some sort of custom property, which means we have to break it before we can implementDataType.is_nested()
as a classmethod.Changes
NESTED_DTYPES
groupDataType.is_nested
, suggest usingdtype in pl.NESTED_DTYPES
instead (until we implementDataType.is_nested()
as a breaking change).@alexander-beedie Any thoughts?