New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(rust): standardize error messages in crate polars-core #11863

Closed

TheDataScientistNL wants to merge 1 commit into pola-rs:main from TheDataScientistNL:standardize_error_messages_rust_crate_polars-core

Contributor

TheDataScientistNL commented Oct 19, 2023

Part of #10421


          feat(rust): standardize error messages in crate polars-core

5931d5e

Part of pola-rs#10421

TheDataScientistNL requested review from ritchie46, stinodego, alexander-beedie and orlp as code owners

October 19, 2023 17:58

github-actions bot added enhancement rust labels

stinodego requested a review from MarcoGorelli as a code owner

November 12, 2023 04:36

Member

stinodego commented Jan 11, 2024

See my comment on the related PR:

Unfortunately I got to review this PR way late. Most of the changes here look good, though when I look at the new error messages, I think structs/enums (e.g. DataType::String) should not be in backticks.

I am closing this because it is not really reviewable anymore due to conflicts. Apologies.

stinodego closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

ritchie46 Awaiting requested review from ritchie46 ritchie46 is a code owner

stinodego Awaiting requested review from stinodego

alexander-beedie Awaiting requested review from alexander-beedie alexander-beedie is a code owner

orlp Awaiting requested review from orlp orlp is a code owner

MarcoGorelli Awaiting requested review from MarcoGorelli MarcoGorelli is a code owner

Labels

enhancement rust