Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix Cargo warning for parquet2 dependency #11882

Merged
merged 2 commits into from
Oct 20, 2023
Merged

Conversation

stinodego
Copy link
Member

@stinodego stinodego commented Oct 20, 2023

Fixes the following warning that appears with every build:

warning: /home/stijn/code/polars/crates/polars-error/Cargo.toml: `default-features` is ignored for parquet2, since `default-features` was true for `workspace.dependencies.parquet2`, this could become a hard error in the future

Unfortunately there is no way to turn these warnings into errors 😕
rust-lang/cargo#2568

Also remove some useless default-features = false entries for dependencies where this is already specified on the workspace level.

@github-actions github-actions bot added internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars labels Oct 20, 2023
@ritchie46 ritchie46 merged commit f509de9 into main Oct 20, 2023
18 checks passed
@ritchie46 ritchie46 deleted the cargo-warning branch October 20, 2023 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants