Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: load 40x40 avatar from github and add loading=lazy attribute. #11886

Merged
merged 2 commits into from
Oct 20, 2023

Conversation

dannyvankooten
Copy link
Contributor

@dannyvankooten dannyvankooten commented Oct 20, 2023

I noticed the documentation index pulled in full size avatars from GitHub. With this change applied, the image is pulled in at the size it is displayed and only after the user scrolls down far enough.

From 1.4MB after gzip to 73 kB.

@github-actions github-actions bot added documentation Improvements or additions to documentation python Related to Python Polars rust Related to Rust Polars labels Oct 20, 2023
@ritchie46
Copy link
Member

Thanks D!

@ritchie46 ritchie46 merged commit 6dae550 into pola-rs:main Oct 20, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants