fix: predicate push-down remove predicate refers to alias for more branch #11887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
fix
reswqa
commented
Oct 20, 2023
| @@ -213,7 +213,7 @@ fn rename_predicate_columns_due_to_aliased_projection( | |||
| ) -> LoopBehavior { | |||
| let projection_aexpr = expr_arena.get(projection_node); | |||
| if let AExpr::Alias(_, alias_name) = projection_aexpr { | |||
| let alias_name = alias_name.as_ref(); | |||
| let alias_name = alias_name.clone(); | |||
There was a problem hiding this comment.
This is to make borrow checker happy.
reswqa
requested review from
ritchie46,
stinodego,
alexander-beedie and
orlp
as code owners
ritchie46
approved these changes
Oct 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #11883. More details see #11883 (comment).