depr(python): Deprecate shift_and_fill in favor of shift
#11955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
deprecation
stinodego
force-pushed
the
shift-fill-depr
branch
from
baba553
to
10ed2b7
Compare
stinodego
requested review from
ritchie46 and
alexander-beedie
as code owners
stinodego
force-pushed
the
shift-fill-depr
branch
from
8ab8825
to
b90a733
Compare
stinodego
force-pushed
the
shift-fill-depr
branch
from
8257512
to
ce4e413
Compare
ritchie46
approved these changes
Oct 24, 2023
stinodego
force-pushed
the
shift-fill-depr
branch
from
0e61c7c
to
681bc65
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10629
In the Python API, it makes a lot of sense for this to be one function, with an optional
fill_value.In the Rust API, it actually makes sense for there to be two separate functions, as there are no default arguments. So I left the Rust side intact.