Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

depr(python): Deprecate clip_min/clip_max in favor of clip #11961

Merged
merged 3 commits into from
Oct 24, 2023
Merged

Conversation

stinodego
Copy link
Member

Closes #10628

In the Python API, it makes a lot of sense for this to be one function, where both bounds are optional.

In the Rust API, it actually makes sense for there to be three separate functions, so I left the Rust side intact.

@github-actions github-actions bot added deprecation Add a deprecation warning to outdated functionality python Related to Python Polars labels Oct 23, 2023
@stinodego stinodego marked this pull request as ready for review October 23, 2023 21:20
@ritchie46 ritchie46 merged commit 18cba0d into main Oct 24, 2023
13 checks passed
@ritchie46 ritchie46 deleted the depr-clip branch October 24, 2023 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deprecation Add a deprecation warning to outdated functionality python Related to Python Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

consolidate clip, clip_max, clip_min
2 participants