Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(rust): fix nearest join_asof if right df only has single row #11969

Closed
wants to merge 1 commit into from
Closed

fix(rust): fix nearest join_asof if right df only has single row #11969

wants to merge 1 commit into from

Conversation

reswqa
Copy link
Collaborator

@reswqa reswqa commented Oct 24, 2023

This fixes #11966.

@github-actions github-actions bot added fix Bug fix rust Related to Rust Polars labels Oct 24, 2023
@ritchie46
Copy link
Member

Thanks @reswqa. I do think we have to wait on #11712 to be sure we don't create many collisions.

There is a good chance the issue is resolved by #11712 as well.

@reswqa
Copy link
Collaborator Author

reswqa commented Oct 24, 2023

Thanks @ritchie46. I almost forgot #11712 :). Agree with your opinion, I will close this PR first, in favor of #11712.

@reswqa reswqa closed this Oct 24, 2023
@reswqa reswqa deleted the as_of_nearest branch October 24, 2023 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ritchie46 ritchie46 Awaiting requested review from ritchie46 ritchie46 will be requested when the pull request is marked ready for review ritchie46 is a code owner

@orlp orlp Awaiting requested review from orlp orlp will be requested when the pull request is marked ready for review orlp is a code owner

@c-peters c-peters Awaiting requested review from c-peters c-peters will be requested when the pull request is marked ready for review c-peters is a code owner

Assignees
No one assigned
Labels
fix Bug fix rust Related to Rust Polars
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

A nearest join_asof with one-row right data frame does not select the row
2 participants
@reswqa @ritchie46