Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

depr(python, rust!): Rename ljust/rjust to pad_end/pad_start #11975

Merged
merged 5 commits into from
Oct 25, 2023
Merged

depr(python, rust!): Rename ljust/rjust to pad_end/pad_start #11975

merged 5 commits into from
Oct 25, 2023

Conversation

stinodego
Copy link
Member

@stinodego stinodego commented Oct 24, 2023 •
edited
Loading

Closes #10959

Changes

  • Rename ljust to pad_end.
  • Rename rjust to pad_start.
  • Rename the width parameter to length - strings don't have a width, they have a length.
  • Rename the alignment parameter of zfill to length.
  • Update docstrings, tests, etc.

@github-actions github-actions bot added breaking rust Change that breaks backwards compatibility for the Rust crate deprecation Add a deprecation warning to outdated functionality python Related to Python Polars rust Related to Rust Polars labels Oct 24, 2023
@stinodego stinodego marked this pull request as ready for review October 24, 2023 13:49
@ritchie46 ritchie46 merged commit 79e5833 into main Oct 25, 2023
31 checks passed
@ritchie46 ritchie46 deleted the depr-ljust branch October 25, 2023 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ritchie46 ritchie46 ritchie46 approved these changes

@c-peters c-peters Awaiting requested review from c-peters c-peters is a code owner

@alexander-beedie alexander-beedie Awaiting requested review from alexander-beedie alexander-beedie is a code owner

@orlp orlp Awaiting requested review from orlp orlp is a code owner

Assignees
No one assigned
Labels
breaking rust Change that breaks backwards compatibility for the Rust crate deprecation Add a deprecation warning to outdated functionality python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename or alias str.ljust and str.rjust with better names
2 participants
@stinodego @ritchie46