fix: binary agg should group aware if literal not a scalar #12043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
fix
reswqa
commented
Oct 26, 2023
| 1 => self.apply_elementwise(ac_l, ac_r, false), | ||
| _ => self.apply_group_aware(ac_l, ac_r), | ||
| }, | ||
| (AggState::Literal(_), AggState::Literal(_)) => self.apply_group_aware(ac_l, ac_r), |
There was a problem hiding this comment.
I'm not sure about this(all literal), but just think they should return the same values for every group. 🤔
There was a problem hiding this comment.
Can we do something smart here? Compute only once and then expand as list over the groups.
There was a problem hiding this comment.
That's reasonable. I updated the code But not sure if this is what you want.
reswqa
commented
Oct 26, 2023
reswqa
requested review from
ritchie46,
stinodego,
alexander-beedie and
orlp
as code owners
ritchie46
requested changes
Oct 26, 2023
| 1 => self.apply_elementwise(ac_l, ac_r, false), | ||
| _ => self.apply_group_aware(ac_l, ac_r), | ||
| }, | ||
| (AggState::Literal(_), AggState::Literal(_)) => self.apply_group_aware(ac_l, ac_r), |
There was a problem hiding this comment.
Can we do something smart here? Compute only once and then expand as list over the groups.
ritchie46
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #11989.