docs(python): use more ergonomic syntax in select/with_columns where possible #12101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
stinodego
requested changes
Oct 29, 2023
Co-authored-by: Stijn de Gooijer <[email protected]>
MarcoGorelli
requested review from
ritchie46,
c-peters and
alexander-beedie
as code owners
|
thank you, and good one for catching #12101 (comment) (my hope is I'd have noticed before marking as 'ready for review', or so I'd like to think)! |
I'm sure you would have - I was done reviewing and then I noticed it was still in draft 😅 woops |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
really minor but I've come across people who were putting square brackets everywhere and didn't know about the improvements from #6667 - so, I'm suggesting to use it more in the docs so people know about it