depr(python,rust!): Rename dt.seconds to dt.total_seconds (likewise for days, hours, minutes, milliseconds, microseconds, and nanoseconds)
#12179
Conversation
… days, hours, minutes, milliseconds, microseconds, and nanoseconds) for temporal types
github-actions
bot
added
internal
stinodego
changed the title
github-actions
bot
added
the
deprecation
MarcoGorelli
requested review from
ritchie46,
c-peters,
stinodego and
alexander-beedie
as code owners
There was a problem hiding this comment.
The original idea of the linked ticket was to have a single method, i.e. dt.seconds , which would work for both datetime columns (gives you a number between 0 - 59) and for duration columns (gives you the duration in seconds).
However, I think your proposal is better. I like keeping second, hour, etc. for datetime types, and then have total_seconds etc. for duration types. Would be good to get @ritchie46 's signoff here though before we make such changes to the public API.
A few minor comments!
stinodego
changed the title
dt.seconds to dt.total_seconds (likewise for days, hours, minutes, milliseconds, microseconds, and nanoseconds)
github-actions
bot
added
breaking rust
| @@ -158,7 +158,7 @@ impl PyExpr { | |||
| ) | |||
| .into() | |||
| } | |||
| fn duration_hours(&self) -> Self { | |||
| fn dt_total_hours(&self) -> Self { | |||
There was a problem hiding this comment.
Looks like these are not on the Rust expression architecture yet - we can add that in a different PR!
There was a problem hiding this comment.
Has my blessing! But as I said, since it's a change to the public API, we should run this by @ritchie46 as well.
|
LGTM. 👍 Thanks for the ping @stinodego |
closes #6445
as mentioned in the issue,
.secondslooks like.secondsfrom pandas / Python stdlib, but it actually equivalent to.total_seconds