Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

depr(python,rust!): Deprecate parse_int in favor of to_integer #12464

Merged
merged 3 commits into from
Nov 15, 2023
Merged

depr(python,rust!): Deprecate parse_int in favor of to_integer #12464

merged 3 commits into from
Nov 15, 2023

Conversation

reswqa
Copy link
Collaborator

@reswqa reswqa commented Nov 15, 2023

This closes #12451.

@github-actions github-actions bot added deprecation Add a deprecation warning to outdated functionality python Related to Python Polars labels Nov 15, 2023
stinodego
stinodego requested changes Nov 15, 2023
View reviewed changes
Copy link
Member

@stinodego stinodego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I have a few small comments.

py-polars/polars/expr/string.py Outdated Show resolved Hide resolved
crates/polars-plan/src/dsl/function_expr/strings.rs Outdated Show resolved Hide resolved
crates/polars-plan/src/dsl/function_expr/strings.rs Outdated Show resolved Hide resolved
@stinodego stinodego changed the title depr(python): Deprecate parse_int in favor of to_integer depr(python,rust!): Deprecate parse_int in favor of to_integer Nov 15, 2023
@github-actions github-actions bot added breaking rust Change that breaks backwards compatibility for the Rust crate rust Related to Rust Polars labels Nov 15, 2023
@reswqa reswqa marked this pull request as ready for review November 15, 2023 09:16
@stinodego
Copy link
Member

Looks good to me, thanks!

@ritchie46 ritchie46 merged commit 55242df into pola-rs:main Nov 15, 2023
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stinodego stinodego stinodego approved these changes

@ritchie46 ritchie46 Awaiting requested review from ritchie46 ritchie46 is a code owner

@c-peters c-peters Awaiting requested review from c-peters c-peters is a code owner

@alexander-beedie alexander-beedie Awaiting requested review from alexander-beedie alexander-beedie is a code owner

@MarcoGorelli MarcoGorelli Awaiting requested review from MarcoGorelli MarcoGorelli is a code owner

@orlp orlp Awaiting requested review from orlp orlp is a code owner

Assignees
No one assigned
Labels
breaking rust Change that breaks backwards compatibility for the Rust crate deprecation Add a deprecation warning to outdated functionality python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Redesign str.parse_int
3 participants
@reswqa @stinodego @ritchie46