-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(python): a user-guide chapter on pipes #16462
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #16462 +/- ##
==========================================
- Coverage 81.50% 81.47% -0.04%
==========================================
Files 1415 1416 +1
Lines 186600 186906 +306
Branches 3014 3026 +12
==========================================
+ Hits 152097 152275 +178
- Misses 33973 34098 +125
- Partials 530 533 +3 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, but I would approach this a bit differenly. See my comment in the linked issue:
It makes sense to add a dedicated section for pipe in the docs, as it's a useful tool for doing custom things. It happens more often that I point out "you can do this with pipe" and people didn't know that method existed.
Not sure I would call it 'debugging with pipe' though. It's useful for more than just debugging.
A "Pipe" page could be added to the "Transformations" section. This could showcase common patterns for using pipe. The schema assertion could be one, but a more important pattern is when you want to "name" some custom transformations and use them in a chaining fashion. We can include examples for Expr, DataFrame, and LazyFrame.
I will try to do it in a week. |
The issues mentioned in the "cookbook" issue are great examples for pipe, e.g. |
@stinodego, in the previous comment you said,
I have tried to fit it there, but it doesn't belong. Transformations: a short list of pre-defined elementary building blocks. User-defined functions with pipes: infinitely many and arbitrarily complex. So I created a new top-level section. What do you think? |
@MarcoGorelli, judging by #17707, @stinodego is taking a break from work on polars. Can you have a look at this? (Mentioning you, because you have reviewed a couple of my previous PRs with documentation improvements.) |
A companion PR to #16461.