Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Resolve multiple SQL JOIN issues #16507

Merged
merged 5 commits into from
May 29, 2024

Conversation

alexander-beedie
Copy link
Collaborator

@alexander-beedie alexander-beedie commented May 26, 2024

Both coalesce-related blockers issue (#16515 and #16554) now resolved ✌️
(Thanks @nameexhaustion!)


Closes #11927.
Closes #13618.
Closes #14217.
Closes #15663.
Closes #15929.

(Confirmed it also fixes #16255 and pola-rs/polars-cli#52).

Updates

  • Introduces a more robust method of tracking aliased columns through joins so that we can correctly resolve them on any follow-up projection/constraint ops.
  • Adds lots of extra test coverage for SQL joins, representing all of the closed issues.

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels May 26, 2024
@alexander-beedie alexander-beedie force-pushed the sql-fix-join-column-select branch 8 times, most recently from c29b8de to 96fc32c Compare May 27, 2024 08:14
@alexander-beedie alexander-beedie added the blocked Cannot be worked on due to external dependencies, or significant new internal features needed first label May 27, 2024
@alexander-beedie alexander-beedie force-pushed the sql-fix-join-column-select branch 2 times, most recently from 5c8ce9c to d7af888 Compare May 27, 2024 12:09
@alexander-beedie alexander-beedie added the A-sql Area: Polars SQL functionality label May 27, 2024
@alexander-beedie alexander-beedie force-pushed the sql-fix-join-column-select branch 4 times, most recently from 3a6e37d to c0f6f68 Compare May 29, 2024 06:47
Copy link

codecov bot commented May 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.48%. Comparing base (0eb8384) to head (fc0278d).
Report is 1 commits behind head on main.

Current head fc0278d differs from pull request most recent head 4c026be

Please upload reports for the commit 4c026be to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16507      +/-   ##
==========================================
- Coverage   81.49%   81.48%   -0.02%     
==========================================
  Files        1414     1412       -2     
  Lines      185561   185524      -37     
  Branches     2997     2996       -1     
==========================================
- Hits       151219   151165      -54     
- Misses      33826    33843      +17     
  Partials      516      516              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alexander-beedie alexander-beedie removed the blocked Cannot be worked on due to external dependencies, or significant new internal features needed first label May 29, 2024
@alexander-beedie alexander-beedie marked this pull request as ready for review May 29, 2024 07:16
Copy link

codspeed-hq bot commented May 29, 2024

CodSpeed Performance Report

Merging #16507 will not alter performance

Comparing alexander-beedie:sql-fix-join-column-select (4c026be) with main (0eb8384)

Summary

✅ 37 untouched benchmarks

@ritchie46
Copy link
Member

Now that's a lot of fixes!

@ritchie46 ritchie46 merged commit a3e116e into pola-rs:main May 29, 2024
29 checks passed
@alexander-beedie alexander-beedie deleted the sql-fix-join-column-select branch May 29, 2024 13:43
Wouittone pushed a commit to Wouittone/polars that referenced this pull request Jun 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-sql Area: Polars SQL functionality fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
2 participants