-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(python)!: Properly apply strict
parameter in Series constructor
#16939
Conversation
5a4e0e9
to
9da204a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #16939 +/- ##
==========================================
+ Coverage 81.02% 81.04% +0.02%
==========================================
Files 1445 1445
Lines 190134 190141 +7
Branches 2712 2709 -3
==========================================
+ Hits 154050 154103 +53
+ Misses 35585 35540 -45
+ Partials 499 498 -1 ☔ View full report in Codecov by Sentry. |
CodSpeed Performance ReportMerging #16939 will improve performances by 19.94%Comparing Summary
Benchmarks breakdown
|
strict
parameter in Series constructor
*, | ||
strict: bool, | ||
) -> PySeries: | ||
"""Construct Series, with fallbacks for basic type mismatch (eg: bool/int).""" | ||
while True: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
auch
Closes #14427
The behavior of the Series constructor has been updated.
Generally, it will be more strict, unless the user passes
strict=False
.Strict construction is more efficient than non-strict construction, so make sure to pass values of the same data type to the constructor for the best performance.
Example
Before:
After: