Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(rust): Remove has_validity, use has_nulls #17519

Merged
merged 3 commits into from
Jul 16, 2024

Conversation

orlp
Copy link
Collaborator

@orlp orlp commented Jul 9, 2024

No description provided.

@github-actions github-actions bot added internal An internal refactor or improvement rust Related to Rust Polars labels Jul 9, 2024
Copy link

codecov bot commented Jul 10, 2024

Codecov Report

Attention: Patch coverage is 70.40816% with 29 lines in your changes missing coverage. Please review.

Project coverage is 80.50%. Comparing base (a5724d6) to head (d502bda).
Report is 4 commits behind head on main.

Files Patch % Lines
py-polars/src/map/series.rs 45.71% 19 Missing ⚠️
...es/polars-core/src/series/implementations/array.rs 0.00% 2 Missing ⚠️
...s-core/src/series/implementations/binary_offset.rs 0.00% 2 Missing ⚠️
...tes/polars-core/src/series/implementations/list.rs 0.00% 2 Missing ⚠️
crates/polars-core/src/chunked_array/ops/apply.rs 0.00% 1 Missing ⚠️
...ates/polars-core/src/chunked_array/ops/chunkops.rs 0.00% 1 Missing ⚠️
crates/polars-core/src/frame/mod.rs 0.00% 1 Missing ⚠️
py-polars/polars/series/series.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #17519      +/-   ##
==========================================
+ Coverage   80.47%   80.50%   +0.03%     
==========================================
  Files        1482     1483       +1     
  Lines      195119   195156      +37     
  Branches     2778     2778              
==========================================
+ Hits       157026   157118      +92     
+ Misses      37582    37527      -55     
  Partials      511      511              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46
Copy link
Member

Can you rebase?

@orlp
Copy link
Collaborator Author

orlp commented Jul 15, 2024

@ritchie46 Done, sorry didn't see notification earlier.

@ritchie46 ritchie46 merged commit 001cc48 into pola-rs:main Jul 16, 2024
27 checks passed
@c-peters c-peters added the accepted Ready for implementation label Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation internal An internal refactor or improvement rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants