Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Make better use of typos configuration features #17800

Merged
merged 3 commits into from
Jul 23, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 25 additions & 26 deletions _typos.toml
Original file line number Diff line number Diff line change
@@ -1,34 +1,33 @@
[default]
extend-ignore-identifiers-re = [
"splitted.*",
[files]
extend-exclude = [
".git/",
"*.csv",
"*.gz",
"dists.dss",
]
ignore-hidden = false

[default.extend-identifiers]
bck = "bck"
Fo = "Fo"
ND = "ND"
ba = "ba"
nd = "nd"
opt_nd = "opt_nd"
ANDed = "ANDed"
ody = "ody"
[default]
extend-ignore-re = [
'"Theatre": \[.+\],',
]

[default.extend-words]
arange = "arange"
strat = "strat"
'"r0ot"' = "r0ot"
wee = "wee"
ser = "ser"
ND = "ND"
ody = "ody"

[type.csv]
extend-glob = ["*.csv"]
check-file = false
splitted = "splitted"
strat = "strat"

[type.gz]
extend-glob = ["*.gz"]
check-file = false
[type.py.extend-identifiers]
ba = "ba"
ody = "ody"

[files]
extend-exclude = ["_typos.toml", "dists.dss"]
[type.rust.extend-identifiers]
ANDed = "ANDed"
bck = "bck"
Fo = "Fo"
ND = "ND"
nd = "nd"
NDJson = "NDJson"
NDJsonReadOptions = "NDJsonReadOptions"
opt_nd = "opt_nd"
2 changes: 1 addition & 1 deletion crates/polars-plan/src/dsl/string.rs
Original file line number Diff line number Diff line change
Expand Up @@ -237,7 +237,7 @@ impl StringNameSpace {
)
}

/// Find the index of a substring defined by a regular expressons within another string value.
/// Find the index of a substring defined by a regular expressions within another string value.
#[cfg(feature = "regex")]
pub fn find(self, pat: Expr, strict: bool) -> Expr {
self.0.map_many_private(
Expand Down
4 changes: 2 additions & 2 deletions py-polars/src/lazyframe/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -599,12 +599,12 @@ impl PyLazyFrame {
Ok((df.into(), time_df.into()))
}

fn collect(&self, py: Python, lamdba_post_opt: Option<PyObject>) -> PyResult<PyDataFrame> {
fn collect(&self, py: Python, lambda_post_opt: Option<PyObject>) -> PyResult<PyDataFrame> {
// if we don't allow threads and we have udfs trying to acquire the gil from different
// threads we deadlock.
let df = py.allow_threads(|| {
let ldf = self.ldf.clone();
if let Some(lambda) = lamdba_post_opt {
if let Some(lambda) = lambda_post_opt {
ldf._collect_post_opt(|root, lp_arena, expr_arena| {
Python::with_gil(|py| {
let nt = NodeTraverser::new(
Expand Down