Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Update Cloud plan preparation #17802

Merged
merged 10 commits into from
Jul 23, 2024
Merged

refactor: Update Cloud plan preparation #17802

merged 10 commits into from
Jul 23, 2024

Conversation

stinodego
Copy link
Member

@stinodego stinodego commented Jul 23, 2024

This introduces a (private) utility function that takes a LazyFrame, adds a sink, checks that it's eligible to be run on Polars Cloud, then serializes it and returns the bytes.

@stinodego stinodego added the skip changelog Do not include in changelog label Jul 23, 2024
@github-actions github-actions bot added internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars labels Jul 23, 2024
@stinodego stinodego marked this pull request as ready for review July 23, 2024 07:35
Copy link
Member

@ritchie46 ritchie46 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, a few small comments.

crates/polars-plan/src/client/check.rs Show resolved Hide resolved
py-polars/src/cloud.rs Outdated Show resolved Hide resolved
crates/polars-plan/src/client/mod.rs Outdated Show resolved Hide resolved
Copy link

codecov bot commented Jul 23, 2024

Codecov Report

Attention: Patch coverage is 88.57143% with 8 lines in your changes missing coverage. Please review.

Project coverage is 80.45%. Comparing base (66f0026) to head (1a9bdd6).
Report is 4 commits behind head on main.

Files Patch % Lines
crates/polars-plan/src/client/check.rs 81.08% 7 Missing ⚠️
crates/polars-plan/src/client/mod.rs 95.23% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #17802      +/-   ##
==========================================
- Coverage   80.47%   80.45%   -0.03%     
==========================================
  Files        1503     1503              
  Lines      197115   196977     -138     
  Branches     2794     2794              
==========================================
- Hits       158628   158474     -154     
- Misses      37973    37989      +16     
  Partials      514      514              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit 9eec688 into main Jul 23, 2024
27 checks passed
@ritchie46 ritchie46 deleted the client-sink branch July 23, 2024 12:44
@c-peters c-peters added the accepted Ready for implementation label Jul 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars skip changelog Do not include in changelog
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants