-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Update Cloud plan preparation #17802
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, a few small comments.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17802 +/- ##
==========================================
- Coverage 80.47% 80.45% -0.03%
==========================================
Files 1503 1503
Lines 197115 196977 -138
Branches 2794 2794
==========================================
- Hits 158628 158474 -154
- Misses 37973 37989 +16
Partials 514 514 ☔ View full report in Codecov by Sentry. |
This introduces a (private) utility function that takes a LazyFrame, adds a sink, checks that it's eligible to be run on Polars Cloud, then serializes it and returns the bytes.