Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(python): Restore accidentally removed deprecated parameters #17818

Merged
merged 1 commit into from
Jul 23, 2024
Merged

fix(python): Restore accidentally removed deprecated parameters #17818

merged 1 commit into from
Jul 23, 2024

Conversation

nameexhaustion
Copy link
Collaborator

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Jul 23, 2024
@nameexhaustion nameexhaustion added skip changelog Do not include in changelog and removed python Related to Python Polars rust Related to Rust Polars fix Bug fix labels Jul 23, 2024
@nameexhaustion nameexhaustion changed the title fix: Restore accidentally removed deprecated parameters fix(python): Restore accidentally removed deprecated parameters Jul 23, 2024
@github-actions github-actions bot added fix Bug fix python Related to Python Polars labels Jul 23, 2024
@nameexhaustion nameexhaustion marked this pull request as ready for review July 23, 2024 16:03
MarcoGorelli
MarcoGorelli approved these changes Jul 23, 2024
View reviewed changes
Copy link
Collaborator

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @nameexhaustion !

@stinodego
Copy link
Member

Thanks! We'll remove these with 2.0.0.

@codecov Codecov
Copy link

codecov bot commented Jul 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.49%. Comparing base (9eec688) to head (ef2d0c8).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #17818   +/-   ##
=======================================
  Coverage   80.49%   80.49%           
=======================================
  Files        1503     1503           
  Lines      197027   197034    +7     
  Branches     2795     2804    +9     
=======================================
+ Hits       158589   158596    +7     
  Misses      37918    37918           
  Partials      520      520

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MarcoGorelli MarcoGorelli merged commit 3981d47 into pola-rs:main Jul 23, 2024
16 checks passed
@nameexhaustion nameexhaustion deleted the depr branch July 28, 2024 10:59
@c-peters c-peters added the accepted Ready for implementation label Jul 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcoGorelli MarcoGorelli MarcoGorelli approved these changes

@ritchie46 ritchie46 Awaiting requested review from ritchie46 ritchie46 is a code owner

@c-peters c-peters Awaiting requested review from c-peters c-peters is a code owner

@alexander-beedie alexander-beedie Awaiting requested review from alexander-beedie alexander-beedie is a code owner

@reswqa reswqa Awaiting requested review from reswqa reswqa is a code owner

Assignees

@nameexhaustion nameexhaustion

Labels
accepted Ready for implementation fix Bug fix python Related to Python Polars skip changelog Do not include in changelog
Projects
Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nameexhaustion @stinodego @MarcoGorelli @c-peters