-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support arithmetic between Series with dtype list #17823
Conversation
Ooh that's a real test failure on Windows, and it's a fun test failure. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17823 +/- ##
==========================================
+ Coverage 79.84% 79.89% +0.05%
==========================================
Files 1518 1519 +1
Lines 205576 205758 +182
Branches 2892 2895 +3
==========================================
+ Hits 164132 164397 +265
+ Misses 40896 40813 -83
Partials 548 548 ☔ View full report in Codecov by Sentry. |
Perhaps this is a feature addition to Rust so the PR title needs to be changed? |
I have (hopefully) addressed the review comments. |
Note I just added better test coverage, which caught a bug in expression type casting, which I fixed but maybe in the wrong place. See commit 85cc6dd above. |
Thanks @itamarst. This is a great addition. 👍 |
Thanks for all the feedback! Next up finishing up my PR for #8006 |
Fixes #9188
Fixes #14541 (mostly was already done, fixes an edge case involving division)
Also includes improvements to array arithmetic testing.
Followup will add support for adding a scalars to a list (and maybe arrays too?), i.e. broadcasting.