feat: Add binary as numerical #19542
Open
+384
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balbok0
requested review from
ritchie46,
c-peters,
alexander-beedie,
MarcoGorelli,
reswqa and
orlp
as code owners
github-actions
bot
added
enhancement
ritchie46
requested changes
Nov 4, 2024
| impl_cast!(f32); | ||
| impl_cast!(f64); | ||
|
|
||
| impl Cast for f16 { |
There was a problem hiding this comment.
We don't support f16, so we can drop this.
| @@ -93,7 +140,8 @@ pub fn binary_to_utf8<O: Offset>( | |||
| } | |||
|
|
|||
| /// Casts a [`BinaryArray`] to a [`PrimitiveArray`], making any uncastable value a Null. | |||
| pub(super) fn binary_to_primitive<O: Offset, T>( | |||
| #[allow(dead_code)] | |||
There was a problem hiding this comment.
Given that this isn't casting anymore, and we shouldn't dispatch to this via cast I think we should move this all much higher int he polars dependency chain.
This should instead be implemented in polars-ops. Only the expressions should call into this and lower it is isn't something we should compile.
| @@ -394,16 +403,26 @@ pub fn cast( | |||
| match to_type { | |||
| BinaryView => Ok(arr.to_binview().boxed()), | |||
| LargeUtf8 => Ok(binview_to::utf8view_to_utf8::<i64>(arr).boxed()), | |||
| UInt8 => binview_to_primitive_dyn::<u8>(&arr.to_binview(), to_type, options), | |||
There was a problem hiding this comment.
And then we can remove all this from the cast kernels as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #18991
Implements
from_buffermethod that casts from Binary to Numerical types. It is not the most efficient (i.e. size + reinterpret cast would probably better), but provides a consistent code for both LE and BE encodings. Name is inspired by numpy equivalent, but with polars style_separator between words.I also added match arm in
castthat goes fromBinary-> numerical type. It assumes LE encoding, as it is a vastly more popular from the two. Happy to remove that part of code, since it does make an unspecified assumption. Lastly, I noticed that there is missing Numerical ->Binaryfunctionality. Out-of-scope for this MR IMO, but something I can do later on.