feat: Enable more dispatch to scan_csv from read_csv #19600
Draft
+57
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
enhancement
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #19600 +/- ##
==========================================
- Coverage 79.83% 79.79% -0.05%
==========================================
Files 1536 1536
Lines 211357 211357
Branches 2445 2449 +4
==========================================
- Hits 168744 168650 -94
- Misses 42058 42148 +90
- Partials 555 559 +4 ☔ View full report in Codecov by Sentry. |
nameexhaustion
added
do not merge
nameexhaustion
commented
Nov 3, 2024
| @@ -385,7 +383,7 @@ def test_dtype_overwrite_with_column_name_selection() -> None: | |||
| ) | |||
| f = io.StringIO(csv) | |||
| df = pl.read_csv(f, columns=["c", "b", "d"], schema_overrides=[pl.Int32, pl.String]) | |||
| assert df.dtypes == [pl.String, pl.Int32, pl.Int64] | |||
There was a problem hiding this comment.
read_csv currently sorts the projection based on column position in the file, which is a bit tricky to handle without breaking changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Experiment to see what would break