docs: Alter examples for round_sig_figs to make behaviour clearer #19667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3tilley
requested review from
ritchie46,
c-peters,
alexander-beedie,
MarcoGorelli and
reswqa
as code owners
3tilley
changed the title
3tilley
changed the title
github-actions
bot
added
documentation
3tilley
changed the title
|
Makes sense. Thanks! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #19667 +/- ##
===========================================
+ Coverage 59.97% 79.73% +19.76%
===========================================
Files 1541 1541
Lines 212010 212010
Branches 2446 2446
===========================================
+ Hits 127151 169049 +41898
+ Misses 84305 42407 -41898
Partials 554 554 ☔ View full report in Codecov by Sentry. |
tylerriccio33
pushed a commit
to tylerriccio33/polars
that referenced
this pull request
Nov 8, 2024
…la-rs#19667) Co-authored-by: Max Tilley <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wondered about the rounding behaviour and ended up putting in a script to test it myself. If I'd seen this example it would have cleared it up for me very quickly!