refactor(rust): Add new streaming CSV source #19694
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
internal
nameexhaustion
commented
Nov 8, 2024
| offset > 0 | ||
| }) && options.parse_options.comment_prefix.is_none() | ||
| && std::env::var("POLARS_NEW_STREAMING_CSV_EXPERIMENTAL_SLICE").as_deref() | ||
| == Ok("1") |
There was a problem hiding this comment.
I have slice pushdown into the CSV source disabled by default - it relies heavily on CountLines being correct.
nameexhaustion
added
blocked
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a simple CSV source - we have one thread scanning for line batches which get sent to other threads for parsing
Note this has merge conflicts with #19454 - specifically in the IR lowering code