Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix incorrect lazy schema for aggregations #19753

Merged
merged 4 commits into from
Nov 13, 2024
+169 −94
Merged

fix: Fix incorrect lazy schema for aggregations #19753

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d99cba3
c
nameexhaustion Nov 13, 2024
44f2a38
c
nameexhaustion Nov 13, 2024
ceba392
c
nameexhaustion Nov 13, 2024
0ebd8aa
c
nameexhaustion Nov 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions .github/workflows/test-coverage.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,9 +96,13 @@ jobs:
with:
python-version: '3.12'

- name: Create virtual environment
- name: Install uv
run: |
curl -LsSf https://astral.sh/uv/install.sh | sh
echo "$HOME/.local/bin" >> "$GITHUB_PATH"
Copy link
Collaborator Author

@nameexhaustion nameexhaustion Nov 13, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

drive-by fix CI, ~/.local/bin needs to be in $PATH to use uv - we only seem to need this on macOS runners

- name: Create virtual environment
run: |
uv venv
echo "$GITHUB_WORKSPACE/.venv/bin" >> $GITHUB_PATH
echo "VIRTUAL_ENV=$GITHUB_WORKSPACE/.venv" >> $GITHUB_ENV
Expand Down Expand Up @@ -165,7 +169,7 @@ jobs:
runs-on: ubuntu-latest

steps:
# Needed to fetch the Codecov config file
# Needed to fetch the Codecov config file
- uses: actions/checkout@v4

- name: Download coverage reports
Expand Down
Loading