-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Make automatic use of Azure storage account keys opt-in #20652
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #20652 +/- ##
==========================================
- Coverage 79.02% 78.96% -0.06%
==========================================
Files 1557 1557
Lines 220551 220727 +176
Branches 2514 2513 -1
==========================================
+ Hits 174283 174301 +18
- Misses 45695 45852 +157
- Partials 573 574 +1 ☔ View full report in Codecov by Sentry. |
eprintln!("[CloudOptions::build_azure]: Permission check OK"); | ||
} | ||
return Ok(store); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Authentication will now prioritize Entra ID (via the Python-side DefaultAzureCredential
if azure.identity
is installed). Using the storage account key will only happen if we get a permission error (above).
ref #20634
This makes automatic authentication using inferred storage account keys opt-in using an environment variable to reduce security concerns.
If this environment variable is unset and we observe an error, we print a message to hint to the user that this is an available option:
[CloudOptions::build_azure]: Warning: Azure authentication check failed, subsequent cloud operations may return an error. Note that polars was able to retrieve the storage account key for this URL from the Azure CLI - to allow polars to automatically use storage account keys for authentication, set POLARS_AUTO_AZURE_ACCOUNT_KEY=1 in the environment. To silence this warning, set POLARS_AUTO_AZURE_ACCOUNT_KEY=0.