fix(python): Validate pl.Array shape argument types
#20915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FBruzzesi
requested review from
ritchie46,
c-peters,
alexander-beedie,
MarcoGorelli and
reswqa
as code owners
FBruzzesi
changed the title
pl.Array shape argument element typespl.Array shape argument types
FBruzzesi
changed the title
pl.Array shape argument typespl.Array shape argument types
github-actions
bot
added
fix
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #20915 +/- ##
==========================================
- Coverage 79.77% 79.77% -0.01%
==========================================
Files 1569 1569
Lines 222897 222898 +1
Branches 2574 2574
==========================================
- Hits 177815 177813 -2
- Misses 44490 44494 +4
+ Partials 592 591 -1 ☔ View full report in Codecov by Sentry. |
FBruzzesi
commented
Jan 25, 2025
|
CI failure unrelated to the change |
alexander-beedie
approved these changes
Jan 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #20914