-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Remove duplicated content in error messages #8107
fix: Remove duplicated content in error messages #8107
Commits on Feb 6, 2024
-
Removed duplicated content in error messages
Prevented exponential growth of error messages by avoiding nesting of error messages Instead, used a counter to track how many operations had been applied to a LazyFrame after an error Renamed `ErrorState` to `ErrorStateEncounters` and made it crate-private Renamed `ErrorStateSync` to `ErrorState` and removed its Deref impl so that the only way to access its data is through (crate-private) accessors, thus reducing the size of its public API
Configuration menu - View commit details
-
Copy full SHA for 85bae1a - Browse repository at this point
Copy the full SHA 85bae1aView commit details -
Improved formatting of ErrorState to avoid exponential growth of back…
…slashes in output Minor cleanup + commenting
Configuration menu - View commit details
-
Copy full SHA for 38310d7 - Browse repository at this point
Copy the full SHA 38310d7View commit details -
Removed duplicated content in error messages
Prevented exponential growth of error messages by avoiding nesting of error messages Instead, used a counter to track how many operations had been applied to a LazyFrame after an error Renamed `ErrorState` to `ErrorStateEncounters` and made it crate-private Renamed `ErrorStateSync` to `ErrorState` and removed its Deref impl so that the only way to access its data is through (crate-private) accessors, thus reducing the size of its public API
Configuration menu - View commit details
-
Copy full SHA for 4204ab0 - Browse repository at this point
Copy the full SHA 4204ab0View commit details -
Configuration menu - View commit details
-
Copy full SHA for af4f778 - Browse repository at this point
Copy the full SHA af4f778View commit details -
Configuration menu - View commit details
-
Copy full SHA for c76729a - Browse repository at this point
Copy the full SHA c76729aView commit details -
Configuration menu - View commit details
-
Copy full SHA for f51b7af - Browse repository at this point
Copy the full SHA f51b7afView commit details -
Configuration menu - View commit details
-
Copy full SHA for f850f3f - Browse repository at this point
Copy the full SHA f850f3fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1887688 - Browse repository at this point
Copy the full SHA 1887688View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1ef40a9 - Browse repository at this point
Copy the full SHA 1ef40a9View commit details -
Improved ErrorState::take() logic
Instead of leaving a `String` in place of `PolarsError`, leave in place the original `PolarsError`. Then, when it's time to produce a new error, we clone the original error if possible; and it's almost always possible, as all `PolarsError` variants contain ErrString as their data except one: `Io`. So just convert `Io` to `ComputeError` with an error message saying so, otherwise reuse the `PolarsError` variant with a cloned message. (This is based off, and utilizes, the method `PolarsError::wrap_msg`.) This way we can retain the "shape" of the original error and just augment its message to indicate that it's already failed n times. Also cleaned up the `err_msg.rs` test in anticipation of adding a bit more to that file.
Configuration menu - View commit details
-
Copy full SHA for 6a103e8 - Browse repository at this point
Copy the full SHA 6a103e8View commit details -
Simplified implementation of error reporting
Now that errors aren't taken and replaced by a String - the original is stored and cloned as needed - we can simplify the implementation. Instead of NotYetEncountered and AlreadyEncountered, we can just have a single struct with a counteer (no enum needed). This massively simplifies the implementation Also, simplified the implemtnation of tests Also cleaned up ErrorState's Debug implementation so that users don't see the nuts and bolts inside the struct - they only see the important debugging info
Configuration menu - View commit details
-
Copy full SHA for 7058c89 - Browse repository at this point
Copy the full SHA 7058c89View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4a4283e - Browse repository at this point
Copy the full SHA 4a4283eView commit details -
Configuration menu - View commit details
-
Copy full SHA for dcb4fe0 - Browse repository at this point
Copy the full SHA dcb4fe0View commit details
Commits on Feb 7, 2024
-
Swapped order of elements in "already failed" error message to improv…
…e display of Python error messages
Configuration menu - View commit details
-
Copy full SHA for 1f9b933 - Browse repository at this point
Copy the full SHA 1f9b933View commit details