-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump rust-polars to 0.32.0 #334
Conversation
new cargo.toml inspired by pola-rs/nodejs-polars#85 |
FYI Polars 0.32.0 was released today. I don't know how much work it is to bump from 0.30.0 to 0.32.0 but it would be really cool to catch up |
Ha then I don't have to do 31 ;) |
…mat, LazyFrame_sort, add Err_plain shorthand, refactor strftime strptime, date_range, $all() $any() has now drop_nulls=TRUE arg, refactor json_extract, common_subplan_eliminatino -> (comm_subplan_elim + comm_subexpr_elim) + docs + fix tests
this takes ages alot of breaking changes in rust-polars to fix, but getting there ... 10 unit tests left to fix |
@etiennebacher yeah lets see if we can get them done next week MSRV test points to rust-polars 32 needs something later than rust 1.65. That might become an issue R-universe and CRAN |
I think there is no problem on R-universe because the R-universe's builder is currently installed with the latest Rust. Let's forget about CRAN :) |
…set all workflows except release to use "release" not "release-optimized"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this!
It seems working fine. Is there any reason why this is still a draft?
Oups, now marked for review :) |
I wonder this will also close #324? |
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just tweaked the NEWS a bit, that's massive so I'd say let's trust the test suite here 😅 thanks @sorhawell !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made some minor updates.
(At first, I installed polars from crates.io, but it didn't work...)
Close #324