Implement $sink_ndjson()
#681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eitsupi
reviewed
Jan 11, 2024
man/IO_sink_ndjson.Rd
Outdated
| \arguments{ | ||
| \item{path}{File path to which the result should be written.} | ||
|
|
||
| \item{maintain_order}{Keep the same order as the original \code{DataFrame}. Setting |
There was a problem hiding this comment.
Is this explanation appropriate for LazyFrame's methods?
There was a problem hiding this comment.
It was the same problem for other sink functions, I harmonized it to have "Lazyframe" instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We might want to wait for the answer to this comment before merging: pola-rs/polars#13533 (comment)