-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Update flake to fix failing build #830
Conversation
Thank you for your contribution. renv is not currently in use and can be removed. @Sicheng-Pan Could you take a look at this? |
Thanks a lot for the patch! The reason I did not add |
@detroyejr Also it's been a while since I last updated the flake lock, so feel free to update it there is no conflict! |
That makes sense. I've removed that from the renv. The flake lock is updated and I didn't see any issues. |
The CI failure of macos-14 is came from the image update actions/runner-images#9394 |
@eitsupi Just to confirm the |
Yes, see #586 |
Got it. Removed the renv package from the flake as well. |
Could you please pull in the main branch? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the help!
Thanks, we are freezing the Rust side in preparation for the 0.14.1 release and will merge it after the 0.14.1 release. |
I've been meaning to try out polars for a while and was pleased to see a flake available. Things didn't build on first run, so I made a few updates to get this working again.
nix flake update
.cargo update -p ahash
- This was the main reason for the build failure. Some recent changes to ahash seems to have broken this and several other libraries. I left all other dependencies alone.patchShebangs ./configure
.One question: in the current main branch, polars is not included as a package dependency in the custom
renv
. A downstream version of this repo did include it but it was removed at some point. I'm wondering if that was omitted on purpose or if that should be added back like so:Without it, I cannot run
nix develop github:pola-rs/r-polars
and get a working version of R with polars available.Tested with
nix develop github:detroyejr/r-polars
. Once everything buildsR -e 'packageVersion("polars")'
returns 0.14.0.9000. The example from the README also works.