Disable claims (non-working) #10116
Merged
Disable claims (non-working) #10116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
polkadot-js-bot
approved these changes
Dec 19, 2023
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10115
This might be an easy fix for the specific issue above, however as per the code comment there is just no way of verifying that it actually works if anything is applied. (Original development as I recall from those involved did have extensive tests for all scenarios, so could be verified as working)
For future reference: the above error stack seems to point to the fact that we don't have
Bufferin the browser context - it may even be more sane if a revival is made to not use the (now very outdated, non-touched) secp256k1 libs and rather use those from@noble/*.