-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use apiSystemPeople for identities on {relay | system} chains, and keep compat for parachains #10598
Conversation
This is almost ready, I just need to also give support for systems using systemPeople and then some tests and the PR should be ready. |
Last i need to ensure a safe way to disable all tx.identity calls for any chain but the people chain. While also keeping support for all parachains and other chains... Also need to ensure the endpoint urls are populated for systemParachains Also need to ensure |
Ready! |
@TarikGul does this change allows for other parachains to register people as their identity provider? |
@pandres95 Yes! For sure, there is one small edge case I would need to fix, but I designed it in a way where any chain can opt in. |
@pandres95 For now though its just system chains, and relay chains that have support. With a follow up PR I will clean up one small piece of logic, then it should only take adding the following to apps config for the parachain you want to opt into the people chain for identities:
Edit: That all being said I dont know how possible it is for a parachain to be able to use the people chain. |
Awesome @TarikGul! Is there a way I can propose that some parachains register themselves as compatible with the relay chain addresses? We have this case where Kreivo (Kusama/2281) uses the same prefix as the relay, is using people chain as provider for identity, and for practical purposes, we expect users not to have to change their accounts in polkadot.js wallet to run on "Any Chain" instead of "Kusama Relay Chain" for their accounts being discoverable in Kreivo. I wanted to propose the concept of relay-compatible. And half of that proposal is included in this PR. |
As I added in an edit above, I actually don't know if a parachain would even be able to opt in to using the People chain as a source of identity. That being said I am definitely not the best person to give a great answer. cc: @joepetrowski |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
The following PR ensures that all necessary chains will now query the people chain for any identity information. This PR also maintains support for any chain that does not use the people chain as their identity source of truth. All parachains and live networks should work as is.
For relay chains, set identity has now been disabled, with the exception of polkadot since it has not made the full migration yet.
Additions to apps config
EndointOption
andLinkOption
isPeople?: boolean;
isRelay?: boolean;
isPeopleForIdentity?: boolean;
relayName?: string;
Additions to
ApiProps
apiIdentity: ApiPromise;
enableIdentity: boolean;
apiSystemPeople: ApiPromise | null;
Additional notes
closes: #10588