Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closing issue #18 #19

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Closing issue #18 #19

wants to merge 1 commit into from

Conversation

davidsteinsland
Copy link

Also fixing bug with division by zero in MethodResults.

This will introduce a new method API, so users should update their method signatures before using this patch.

  • classSetUp(array $methods)
  • setUpMethod($method, $iterationsCount)
  • tearDownMethod($method, $iterationsCount)
  • setUp($method, $currentIteration, $iterationsCount)
  • tearDown($method, $iterationsCount)

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 738c4ed on davidsteinsland:feature-callback-arguments into 43fcde8 on polyfractal:master.

@polyfractal
Copy link
Owner

Hey, sorry for the delay on this. I was traveling when the PR came in and then just plain forgot about it.

I'm in agreement about making the methods protected, and adding callbacks for pre/post method. I'm a little unsure about the argument changes though.

  • What do you gain by adding the list of methods to class setUp ?
  • Why do you need to know the currentIteration and iterationCount? Wouldn't the setup be the same regardless of which iteration you are on? Otherwise you won't have apples-to-apples comparison.

Not saying I'm against these changes, just trying to get an understanding how they will be used. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants