-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Docker Setup #452
Merged
Merged
Improve Docker Setup #452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gartens
force-pushed
the
docker-refactor
branch
3 times, most recently
from
July 25, 2023 09:36
4d7cd88
to
5d605ca
Compare
Work in progress.
Some other minor improvements as well.
Work in progress
vogti
reviewed
Jul 28, 2023
vogti
reviewed
Jul 28, 2023
vogti
reviewed
Jul 28, 2023
vogti
reviewed
Jul 29, 2023
vogti
reviewed
Jul 29, 2023
vogti
reviewed
Jul 29, 2023
vogti
reviewed
Jul 29, 2023
core/src/main/java/org/polypheny/db/docker/PolyphenyCertificateUtils.java
Show resolved
Hide resolved
vogti
reviewed
Jul 29, 2023
vogti
reviewed
Jul 29, 2023
core/src/main/java/org/polypheny/db/docker/PolyphenyHandshakeClient.java
Show resolved
Hide resolved
vogti
reviewed
Jul 29, 2023
vogti
reviewed
Jul 29, 2023
The adapter tests do a very good job implicitly testing the new Docker classes. Unit tests are hard because all interesting methods depend on being connected to Docker.
Creating a graph namespace on an adapter with an underscore in the name causes problems at the moment.
vogti
approved these changes
Aug 3, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx, @gartens, for this PR!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This improves how Docker connections are handled in Polypheny.
Changes
The connection to docker happens via a new
polypheny-docker-connector
container. Most of the docker logic is inside of that container, Polypheny communicates with it using protobuf messages. Connections to new Docker hosts are established using a new handshake protocol.Features
Additional Changes and Minor Fixes
There is a corresponding PR for the Polypheny-UI.