Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Docker Setup #452

Merged
merged 95 commits into from
Aug 3, 2023
Merged

Improve Docker Setup #452

merged 95 commits into from
Aug 3, 2023

Conversation

gartens
Copy link
Contributor

@gartens gartens commented Jul 20, 2023 •
edited by vogti
Loading

Summary

This improves how Docker connections are handled in Polypheny.

Changes

The connection to docker happens via a new polypheny-docker-connector container. Most of the docker logic is inside of that container, Polypheny communicates with it using protobuf messages. Connections to new Docker hosts are established using a new handshake protocol.

Features

  • The exposed ports are chosen automatically by Docker, so the user no longer needs to specify them manually
  • Passwords for containers, when applicable, are chosen by Polypheny
  • Each Polypheny instance now has an UUID. This UUID is used in the name of containers, making collisions of container names between different instances unlikely.
  • Adapters are keeping track of the UUID of the deployed Docker container. This information is used to reconnect to the right container on a restart.
  • Most of the options in the adapter setup dialog have been removed for Docker setups

Additional Changes and Minor Fixes

  • Improve parsing of comments in SQL queries submitted through the Polypheny UI.
  • Fix an issue with creating graph namespaces (see corresponding UI PR).
  • Suggest names for adapters, simplifying the adapter deployment.

There is a corresponding PR for the Polypheny-UI.

@gartens gartens mentioned this pull request Jul 20, 2023
Merged
@gartens gartens force-pushed the docker-refactor branch 3 times, most recently from 4d7cd88 to 5d605ca Compare July 25, 2023 09:36
@gartens
Initial draft of the docker refactoring
39688b5 
Work in progress.
@gartens
Fix remote deployment for MongoDB
5ade2ce
@gartens
Collect certificate related paths into one class
3995820
@gartens
Rename HandshakeHelper to HandshakeManager
7a88825 
Some other minor improvements as well.
@gartens
Update for UI
9e253cc 
Work in progress
@gartens
Change how Docker instances are added after a successful handshake
e070842
@gartens
Fix AutoDocker
e919d02
@gartens
UI needs the current state
fed244f
@gartens
Use *.of() instead of Collections.EMPTY_*
62d0f78
@gartens
Make AutoDocker use more of DockerSetupHelper
8876aa4
@gartens
First step to fix the tests
32b2214
@gartens
Set a special UUID when in test mode
31ad007
@gartens
Make sure that docker instances are configured as expected by tests
66076e7
@gartens
Handle the "empty" case by throwing a RuntimeException with an approp…
498320a 
…riate message
@gartens
The polypheny-connector container is no longer needed
67efb7d
@gartens
Depend on protobuf explicitly so core gets the right version when tes…
361dc17 
…ting
@gartens
Port is no longer a setting for neo4j
61a2ff6
@gartens
CQL needs the same fix as dbms for protobuf
8afbaea
@gartens
Allow BSD-3-Clause, dbms does so as well
6e67e9e
@gartens
Update workflows
3615759
@gartens
Use more restrictive access levels in PolyphenyTlsClient and Polyphen…
c118a55 
…yDockerClient
@gartens
Remove unused uuid field in ConfigDocker
a09f0a7
@gartens
Reduce to only one ContainerBuilder
561ec73
@gartens
Small tweaks to DockerInstance and DockerManager
4750bcd
@gartens
Existing hostname is an error
afa74a5
@gartens
More cleanups
2a768f8
gartens and others added 10 commits August 2, 2023 08:54
@gartens
Add missing copyright
c5c97c8
@gartens
Make splitStatements a Processor method
6058f9b
@gartens
Check client for null
7935799
@gartens
Fix test
36a4653
@gartens
Handle invalid docker instance ids
e5e00c4
@gartens
Remove docker tests
9d5b32b 
The adapter tests do a very good job implicitly testing the new Docker classes.  Unit tests are hard because all interesting methods depend on being connected to Docker.
@gartens
Fix build
b0f2b4f
@vogti
Fix a regression. Mongo and Neo4j are always to be treated as persistent
11fb2dc
@gartens
Disallow underscores in adapter names
123607d 
Creating a graph namespace on an adapter with an underscore in the
name causes problems at the moment.
@gartens
Remove some debug messages
18902b8
@vogti vogti self-requested a review August 3, 2023 09:00
vogti
vogti approved these changes Aug 3, 2023
View reviewed changes
Copy link
Member

@vogti vogti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx, @gartens, for this PR!

@vogti vogti merged commit a3b44f4 into master Aug 3, 2023
34 checks passed
@vogti vogti deleted the docker-refactor branch August 3, 2023 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vogti vogti vogti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gartens @vogti