Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proto Query Interface #494

Merged
merged 2,164 commits into from
Apr 19, 2024
Merged

Proto Query Interface #494

merged 2,164 commits into from
Apr 19, 2024

Conversation

TobiasHafner
Copy link
Contributor

@TobiasHafner TobiasHafner commented Apr 17, 2024

This pull request introduces a new query interface plugin called the Proto Interface, designed to enhance Polypheny's capability by enabling multimodel querying through a protobuf and gRPC-based protocol.

Changes

  • Architecture Expansion: A new interface plugin was added, and a new protobuf and gRPC-based protocol implemented.

Features

  • Proto Interface Plugin: A new plugin facilitating multimodel querying capabilities across different data models using protobuf and gRPC.

Tests

  • Integration Tests: Implemented to ensure the Proto Interface correctly interacts with existing Polypheny components.
  • Performance Tests: Conducted to verify that the introduction of the new interface does not adversely affect the system's performance.

Notice

The plugin is not enabled, and the interface is not deployed by default. This will happen as part of a second pull request that introduces additional improvements. Further, this new interface will, as part of this next PR, also be renamed to Prism-Interface.

@vogti vogti changed the title ProtoInterface Prism Query Interface Apr 18, 2024
@vogti vogti changed the title Prism Query Interface Proto Query Interface Apr 18, 2024
Copy link
Member

@datomo datomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @TobiasHafner, this looks good.

Copy link
Member

@vogti vogti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx, @TobiasHafner, for this PR!

@vogti vogti merged commit 45bb497 into master Apr 19, 2024
38 checks passed
@vogti vogti deleted the proto-interface branch April 19, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants