Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve transaction handling in Prism Driver & Decimal validation #514

Merged
merged 13 commits into from
Oct 19, 2024

Conversation

gartens
Copy link
Contributor

@gartens gartens commented Aug 29, 2024

The main contribution of this PR are improvements to transaction handling in the Prism driver and decimal validation:

  • Ensure that statements objects used in the Prism driver belong to the current transaction (with a test that would have exposed this)
  • Ignore leading 0 in decimal number validation to match the documentation
  • Throw an exception when trying to create a statement for an inactive transaction (this exposed an issue in anyPrepareQuery)
  • Improve type derivation in prepared statements
  • Replace a few subtractions with the more appropriate Integer.compare

Copy link
Member

@vogti vogti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx, @gartens and @datomo, for this PR!

@vogti vogti merged commit 5da9c7e into master Oct 19, 2024
29 of 32 checks passed
@vogti vogti deleted the connection-fixes branch October 19, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants